Add plugin: Hot Strings #5110
Open
Add plugin: Hot Strings #5110
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello!I found the following issues in your plugin submission Errors: ❌ Please don't use the word This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
wakywayne
changed the title
this is my second attempt after I had to decrease the length of my description
|
I hope that you guys like my plugin 😄 |
|
The automated review has not found any issues with your code, ready for manual review. |
|
# Obsidian Hotstrings Plugin "description": "Allows you to set custom hot strings that get expanded to text once typed.", |
joethei
added
Changes requested
Minor changes requested
|
Thank you for contacting me regarding my plugin. I have made all of the
requested changes.
…On Thu, Jan 23, 2025 at 4:35 PM Johannes Theiner ***@***.***> wrote:
# Obsidian Hotstrings Plugin
<https://github.com/wakywayne/obsidian-hotstrings/blob/91c36826128e88d648df934d8c96c1d1e8147534/README.md#L1>
Naming something "Obsidian xyz" is reserved for first party products we
create, please change this header.
"description": "Allows you to set custom hot strings that get expanded to
text once typed.",
<https://github.com/wakywayne/obsidian-hotstrings/blob/91c36826128e88d648df934d8c96c1d1e8147534/manifest.json#L6>
Try to avoid starting your description with "Allows you to" or similar
wording.
A lot of plugin descriptions already use that, it's getting a bit
repetitive.
We have published a guide for plugin descriptions to follow here:
https://docs.obsidian.md/Plugins/Releasing/Submission+requirements+for+plugins#Keep+plugin+descriptions+short+and+simple
.
name: "Reload Hotstrings",
<https://github.com/wakywayne/obsidian-hotstrings/blob/91c36826128e88d648df934d8c96c1d1e8147534/main.ts#L21>
Use sentence case in UI
<https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Use+sentence+case+in+UI>
—
Reply to this email directly, view it on GitHub
<#5110 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASJ4EXLL5TOPVT7H3OK2QOD2MFODFAVCNFSM6AAAAABU5O3G3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJRGA3DKMRTGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
ObsidianReviewBot
added
Ready for review
Changes made
and removed
Changes requested
Minor changes requested
|
Hey just following up. I am excited to participate in the Obsidian
community and I made all of the mentioned changes
…On Fri, Jan 24, 2025, 11:35 AM Wayne Wrestler ***@***.***> wrote:
Thank you for contacting me regarding my plugin. I have made all of the
requested changes.
On Thu, Jan 23, 2025 at 4:35 PM Johannes Theiner ***@***.***>
wrote:
> # Obsidian Hotstrings Plugin
> <https://github.com/wakywayne/obsidian-hotstrings/blob/91c36826128e88d648df934d8c96c1d1e8147534/README.md#L1>
> Naming something "Obsidian xyz" is reserved for first party products we
> create, please change this header.
>
> "description": "Allows you to set custom hot strings that get expanded to
> text once typed.",
> <https://github.com/wakywayne/obsidian-hotstrings/blob/91c36826128e88d648df934d8c96c1d1e8147534/manifest.json#L6>
> Try to avoid starting your description with "Allows you to" or similar
> wording.
> A lot of plugin descriptions already use that, it's getting a bit
> repetitive.
> We have published a guide for plugin descriptions to follow here:
> https://docs.obsidian.md/Plugins/Releasing/Submission+requirements+for+plugins#Keep+plugin+descriptions+short+and+simple
> .
>
> name: "Reload Hotstrings",
> <https://github.com/wakywayne/obsidian-hotstrings/blob/91c36826128e88d648df934d8c96c1d1e8147534/main.ts#L21>
> Use sentence case in UI
> <https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Use+sentence+case+in+UI>
>
> —
> Reply to this email directly, view it on GitHub
> <#5110 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ASJ4EXLL5TOPVT7H3OK2QOD2MFODFAVCNFSM6AAAAABU5O3G3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJRGA3DKMRTGI>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
Hey I know you guys are busy with the new version of Obsidian. I am really
happy with it! The automatic numbered list reordering is a huge time saver
for me, thank you. I'm just following up, as I'm excited to participate in
the Obsidian community and I made all of the previously mentioned changes.
…On Mon, Jan 27, 2025, 7:33 PM Wayne Wrestler ***@***.***> wrote:
Hey just following up. I am excited to participate in the Obsidian
community and I made all of the mentioned changes
On Fri, Jan 24, 2025, 11:35 AM Wayne Wrestler ***@***.***>
wrote:
> Thank you for contacting me regarding my plugin. I have made all of the
> requested changes.
>
> On Thu, Jan 23, 2025 at 4:35 PM Johannes Theiner <
> ***@***.***> wrote:
>
>> # Obsidian Hotstrings Plugin
>> <https://github.com/wakywayne/obsidian-hotstrings/blob/91c36826128e88d648df934d8c96c1d1e8147534/README.md#L1>
>> Naming something "Obsidian xyz" is reserved for first party products we
>> create, please change this header.
>>
>> "description": "Allows you to set custom hot strings that get expanded
>> to text once typed.",
>> <https://github.com/wakywayne/obsidian-hotstrings/blob/91c36826128e88d648df934d8c96c1d1e8147534/manifest.json#L6>
>> Try to avoid starting your description with "Allows you to" or similar
>> wording.
>> A lot of plugin descriptions already use that, it's getting a bit
>> repetitive.
>> We have published a guide for plugin descriptions to follow here:
>> https://docs.obsidian.md/Plugins/Releasing/Submission+requirements+for+plugins#Keep+plugin+descriptions+short+and+simple
>> .
>>
>> name: "Reload Hotstrings",
>> <https://github.com/wakywayne/obsidian-hotstrings/blob/91c36826128e88d648df934d8c96c1d1e8147534/main.ts#L21>
>> Use sentence case in UI
>> <https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Use+sentence+case+in+UI>
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#5110 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/ASJ4EXLL5TOPVT7H3OK2QOD2MFODFAVCNFSM6AAAAABU5O3G3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJRGA3DKMRTGI>
>> .
>> You are receiving this because you authored the thread.Message ID:
>> ***@***.***>
>>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am submitting a new Community Plugin
Repo URL
Link to my plugin: https://github.com/wakywayne/obsidian-hotstrings
Release Checklist
main.jsmanifest.jsonstyles.css(optional)v)idin mymanifest.jsonmatches theidin thecommunity-plugins.jsonfile.I have given proper attribution to these other projects in my
README.md.